rommapp/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-02-18 23:42:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor tab synchronization logic to simplify URL change handling in GameDetails.vue

Browse Source
This commit is contained in:
zurdi
2025-11-19 22:48:51 +00:00
parent c1fe3895f8
commit 033eae8299
1 changed files with 3 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
frontend/src/views/GameDetails.vue
View File

@@ -127,27 +127,12 @@ watch(tab, (newTab) => {
}
});
// Watch for URL changes and update tab
// Type guard for valid tab names
function isValidTab(tab: unknown): tab is (
| "details"
| "manual"
| "gamedata"
| "personal"
| "timetobeat"
| "additionalcontent"
| "screenshots"
| "relatedgames"
) {
return typeof tab === "string" && validTabs.includes(tab);
}
watch(
() => route.query.tab,
(newTab) => {
if (isValidTab(newTab)) {
if (tab.value !== newTab) {
tab.value = newTab;
if (newTab && validTabs.includes(newTab as any)) {
if (tab.value !== newTab && typeof newTab === "string") {
tab.value = newTab as typeof tab.value;
}
}
},