From 033eae829982aab247167f20ef02e3a63e3300a6 Mon Sep 17 00:00:00 2001 From: zurdi Date: Wed, 19 Nov 2025 22:48:51 +0000 Subject: [PATCH] Refactor tab synchronization logic to simplify URL change handling in GameDetails.vue --- frontend/src/views/GameDetails.vue | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/frontend/src/views/GameDetails.vue b/frontend/src/views/GameDetails.vue index 6aee23b97..0aefbb126 100644 --- a/frontend/src/views/GameDetails.vue +++ b/frontend/src/views/GameDetails.vue @@ -127,27 +127,12 @@ watch(tab, (newTab) => { } }); -// Watch for URL changes and update tab -// Type guard for valid tab names -function isValidTab(tab: unknown): tab is ( - | "details" - | "manual" - | "gamedata" - | "personal" - | "timetobeat" - | "additionalcontent" - | "screenshots" - | "relatedgames" -) { - return typeof tab === "string" && validTabs.includes(tab); -} - watch( () => route.query.tab, (newTab) => { - if (isValidTab(newTab)) { - if (tab.value !== newTab) { - tab.value = newTab; + if (newTab && validTabs.includes(newTab as any)) { + if (tab.value !== newTab && typeof newTab === "string") { + tab.value = newTab as typeof tab.value; } } },