rommapp/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-02-18 00:27:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3000 from rommapp/romm-2983

Browse Source 
[ROMM-2983] Fix negative filter by verified
This commit is contained in:
Georges-Antoine Assi
2026-02-07 17:52:01 -05:00
committed by GitHub
parent a902950980 4733a86302
commit 8b359a987d
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
backend/handler/database/roms_handler.py
View File

@@ -330,7 +330,7 @@ class DBRomsHandler(DBBaseHandler):
predicate = not_(predicate)
return query.filter(predicate)
def _filter_by_verified(self, query: Query):
def _filter_by_verified(self, query: Query, value: bool) -> Query:
keys_to_check = [
"tosec_match",
"mame_arcade_match",
@@ -347,11 +347,17 @@ class DBRomsHandler(DBBaseHandler):
conditions = " OR ".join(
f"(hasheous_metadata->>'{key}')::boolean" for key in keys_to_check
)
return query.filter(text(conditions))
predicate = text(f"({conditions})")
if not value:
predicate = text(f"NOT ({conditions})")
return query.filter(predicate)
else:
return query.filter(
or_(*(Rom.hasheous_metadata[key].as_boolean() for key in keys_to_check))
predicate = or_(
*(Rom.hasheous_metadata[key].as_boolean() for key in keys_to_check)
)
if not value:
predicate = not_(predicate)
return query.filter(predicate)
def _filter_by_genres(
self,
@@ -587,9 +593,8 @@ class DBRomsHandler(DBBaseHandler):
if missing is not None:
query = self._filter_by_missing_from_fs(query, value=missing)
# TODO: Correctly support true/false values.
if verified:
query = self._filter_by_verified(query)
if verified is not None:
query = self._filter_by_verified(query, value=verified)
if updated_after:
query = query.filter(Rom.updated_at > updated_after)