rommapp/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-02-18 00:27:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Applied feedback from gemini code assist review.

Browse Source
This commit is contained in:
DevOldSchool
2026-01-05 12:38:07 +10:00
parent 86a6804447
commit 331ed76187
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
backend/models/rom.py
View File

@@ -136,7 +136,7 @@ class RomMetadata(BaseModel):
companies: Mapped[list[str] | None] = mapped_column(CustomJSON(), default=[])
game_modes: Mapped[list[str] | None] = mapped_column(CustomJSON(), default=[])
age_ratings: Mapped[list[str] | None] = mapped_column(CustomJSON(), default=[])
player_count: Mapped[str | None] = mapped_column(String(length=100), default=1)
player_count: Mapped[str | None] = mapped_column(String(length=100), default="1")
first_release_date: Mapped[int | None] = mapped_column(BigInteger(), default=None)
average_rating: Mapped[float | None] = mapped_column(default=None)

6
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue
View File

@@ -156,9 +156,9 @@ const onFilterChange = debounce(
playerCounts:
selectedPlayerCounts.value.length > 0
? selectedPlayerCounts.value.join(",")
: 1,
: null,
playerCountsLogic:
selectedPlayerCounts.value.length > 0 ? playerCountsLogic.value : 1,
selectedPlayerCounts.value.length > 0 ? playerCountsLogic.value : null,
}).forEach(([key, value]) => {
if (value) {
url.searchParams.set(key, value);
@@ -359,7 +359,7 @@ function setFilters() {
...new Set(romsForFilters.flatMap((rom) => rom.languages).sort()),
]);
galleryFilterStore.setFilterPlayerCounts([
...new Set(romsForFilters.flatMap((rom) => rom.metadatum.player_count).sort(),
...new Set(romsForFilters.map((rom) => rom.metadatum.player_count).filter(Boolean).sort(),
),
]);
// Note: filterStatuses is static and doesn't need to be set dynamically