rommapp/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-02-18 00:27:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2804 from rommapp/romm-2791

Browse Source 
[ROMM-2791] Stop filtering out None values in order_by filter
This commit is contained in:
Georges-Antoine Assi
2025-12-24 10:16:05 -05:00
committed by GitHub
parent 50aef445c4 ace8ed3679
commit 2b6788b0fc
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/handler/database/roms_handler.py
View File

@@ -620,12 +620,10 @@ class DBRomsHandler(DBBaseHandler):
if user_id and hasattr(RomUser, order_by) and not hasattr(Rom, order_by):
order_attr = getattr(RomUser, order_by)
query = query.filter(RomUser.user_id == user_id, order_attr.isnot(None))
query = query.filter(RomUser.user_id == user_id)
elif hasattr(RomMetadata, order_by) and not hasattr(Rom, order_by):
order_attr = getattr(RomMetadata, order_by)
query = query.outerjoin(RomMetadata, RomMetadata.rom_id == Rom.id).filter(
order_attr.isnot(None)
)
query = query.outerjoin(RomMetadata, RomMetadata.rom_id == Rom.id)
elif hasattr(Rom, order_by):
order_attr = getattr(Rom, order_by)
else: