booklore-app/booklore
1
0
Fork 0
mirror of https://github.com/booklore-app/booklore.git synced 2026-02-19 07:50:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(epub): strip formatting from ISBN values to ensure correct extraction (#2248)

Browse Source 
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
This commit is contained in:
Balázs Szücs
2026-01-13 01:00:52 +01:00
committed by GitHub
parent 8dd9b28552
commit 64f036fb71
2 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
booklore-api/src/main/java/com/adityachandel/booklore/service/metadata/extractor/EpubMetadataExtractor.java
View File

@@ -223,8 +223,9 @@ public class EpubMetadataExtractor implements FileMetadataExtractor {
if (!scheme.isEmpty()) {
switch (scheme) {
case "ISBN" -> {
if (value.length() == 13) builderMeta.isbn13(value);
else if (value.length() == 10) builderMeta.isbn10(value);
String cleanValue = value.replaceAll("[- ]", "");
if (cleanValue.length() == 13) builderMeta.isbn13(value);
else if (cleanValue.length() == 10) builderMeta.isbn10(value);
}
case "GOODREADS" -> builderMeta.goodreadsId(value);
case "COMICVINE" -> builderMeta.comicvineId(value);
@@ -235,8 +236,9 @@ public class EpubMetadataExtractor implements FileMetadataExtractor {
}
} else {
if (text.toLowerCase().startsWith("isbn:")) {
if (value.length() == 13) builderMeta.isbn13(value);
else if (value.length() == 10) builderMeta.isbn10(value);
String cleanValue = value.replaceAll("[- ]", "");
if (cleanValue.length() == 13) builderMeta.isbn13(value);
else if (cleanValue.length() == 10) builderMeta.isbn10(value);
}
}
}

13
booklore-api/src/test/java/com/adityachandel/booklore/service/metadata/extractor/EpubMetadataExtractorTest.java
View File

@@ -386,6 +386,19 @@ class EpubMetadataExtractorTest {
() -> assertEquals("1234567890", result.getIsbn10())
);
}
@Test
@DisplayName("Should extract formatted ISBN-10 as ISBN-10, not ISBN-13")
void extractMetadata_withFormattedIsbn10_returnsIsbn10() throws IOException {
// "90-206-1280-8" is 13 characters long, causing it to be mistaken for ISBN-13 if formatting isn't stripped
File epubFile = createEpubWithIsbn(null, "90-206-1280-8");
BookMetadata result = extractor.extractMetadata(epubFile);
assertNotNull(result);
assertEquals("90-206-1280-8", result.getIsbn10());
assertNull(result.getIsbn13(), "Should not set ISBN-13 for a formatted ISBN-10");
}
}
@Nested