From ee2bd57475016c29c0a9d7eaf5681e551c8a99bb Mon Sep 17 00:00:00 2001
From: Georges-Antoine Assi <contact@me.gantoine.com>
Date: Wed, 27 Aug 2025 18:19:35 -0400
Subject: [PATCH] fixes from review

---
 .devcontainer/devcontainer.json | 4 ++--
 docker-compose.yml              | 2 +-
 frontend/vite.config.js         | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index f6d753c34..b85adaeda 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -4,9 +4,9 @@
   "service": "romm-dev",
   "workspaceFolder": "/app",
   "shutdownAction": "stopCompose",
-  "forwardPorts": [443, 3000, 3306, 5000, 6379],
+  "forwardPorts": [8443, 3000, 3306, 5000, 6379],
   "portsAttributes": {
-    "443": {
+    "8443": {
       "label": "HTTPS Dev Server",
       "onAutoForward": "notify"
     },
diff --git a/docker-compose.yml b/docker-compose.yml
index 6ffceec0b..db2ac0415 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -13,7 +13,7 @@ services:
       - ROMM_BASE_PATH=/app/romm
     ports:
       - "3000:3000" # Frontend dev server
-      - "443:443" # HTTPS dev server
+      - "8443:8443" # HTTPS dev server
       - "${DEV_PORT:-5000}:5000" # Backend API
     volumes:
       - ./backend:/app/backend
diff --git a/frontend/vite.config.js b/frontend/vite.config.js
index 26132b313..2adfa113b 100644
--- a/frontend/vite.config.js
+++ b/frontend/vite.config.js
@@ -80,7 +80,7 @@ export default defineConfig(({ mode }) => {
           rewrite: (path) => path.replace(/^\/openapi.json/, "/openapi.json"),
         },
       },
-      port: env.DEV_HTTPS ? 443 : 3000,
+      port: env.DEV_HTTPS ? 8443 : 3000,
       allowedHosts: ["localhost", "127.0.0.1", "romm.dev"],
       ...(env.DEV_HTTPS
         ? {