From 5f1d39c8f84aa2ab93eff49f0289fdbb610a8033 Mon Sep 17 00:00:00 2001 From: zurdi Date: Tue, 13 May 2025 09:31:06 +0000 Subject: [PATCH] refactor: remove RETROACHIEVEMENTS_USERNAME from docker env variables --- backend/config/__init__.py | 1 - backend/handler/metadata/ra_handler.py | 7 ++----- env.template | 1 - examples/docker-compose.example.yml | 1 - 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/backend/config/__init__.py b/backend/config/__init__.py index 295a892d9..583f333bc 100644 --- a/backend/config/__init__.py +++ b/backend/config/__init__.py @@ -65,7 +65,6 @@ SCREENSCRAPER_PASSWORD: Final = os.environ.get("SCREENSCRAPER_PASSWORD", "") STEAMGRIDDB_API_KEY: Final = os.environ.get("STEAMGRIDDB_API_KEY", "").strip() # RETROACHIEVEMENTS -RETROACHIEVEMENTS_USERNAME: Final = os.environ.get("RETROACHIEVEMENTS_USERNAME", "") RETROACHIEVEMENTS_API_KEY: Final = os.environ.get("RETROACHIEVEMENTS_API_KEY", "") REFRESH_RETROACHIEVEMENTS_CACHE_DAYS: Final = int( os.environ.get("REFRESH_RETROACHIEVEMENTS_CACHE_DAYS", 30) diff --git a/backend/handler/metadata/ra_handler.py b/backend/handler/metadata/ra_handler.py index bd60c8683..f69b480e5 100644 --- a/backend/handler/metadata/ra_handler.py +++ b/backend/handler/metadata/ra_handler.py @@ -12,7 +12,6 @@ from config import ( REFRESH_RETROACHIEVEMENTS_CACHE_DAYS, RESOURCES_BASE_PATH, RETROACHIEVEMENTS_API_KEY, - RETROACHIEVEMENTS_USERNAME, ) from fastapi import HTTPException, status from logger.logger import log @@ -21,10 +20,8 @@ from utils.context import ctx_httpx_client from .base_hander import MetadataHandler -# Used to display the Mobygames API status in the frontend -RA_API_ENABLED: Final = bool(RETROACHIEVEMENTS_API_KEY) and bool( - RETROACHIEVEMENTS_USERNAME -) +# Used to display the Retroachievements API status in the frontend +RA_API_ENABLED: Final = bool(RETROACHIEVEMENTS_API_KEY) class RAGamesPlatform(TypedDict): diff --git a/env.template b/env.template index 323a63e3e..4edbc74a5 100644 --- a/env.template +++ b/env.template @@ -23,7 +23,6 @@ STEAMGRIDDB_API_KEY= # RetroAchievements RETROACHIEVEMENTS_API_KEY= -RETROACHIEVEMENTS_USERNAME= # Database config DB_HOST=127.0.0.1 diff --git a/examples/docker-compose.example.yml b/examples/docker-compose.example.yml index d7a9a74b0..d2322fb1a 100644 --- a/examples/docker-compose.example.yml +++ b/examples/docker-compose.example.yml @@ -23,7 +23,6 @@ services: - SCREENSCRAPER_USER= # Use your ScreenScraper username and password - SCREENSCRAPER_PASSWORD= # https://docs.romm.app/latest/Getting-Started/Generate-API-Keys/#screenscraper - RETROACHIEVEMENTS_API_KEY= # https://api-docs.retroachievements.org/#api-access - - RETROACHIEVEMENTS_USERNAME= # https://api-docs.retroachievements.org/#api-access volumes: - romm_resources:/romm/resources # Resources fetched from IGDB (covers, screenshots, etc.) - romm_redis_data:/redis-data # Cached data for background tasks