From 4a9a326ab64b6660a8a34902970a7fc2ce669c24 Mon Sep 17 00:00:00 2001 From: DevOldSchool Date: Sun, 11 Jan 2026 13:41:24 +1000 Subject: [PATCH] Updates from code review feedback. --- .../versions/0063_roms_metadata_player_count.py | 2 ++ backend/handler/metadata/igdb_handler.py | 10 +++------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/backend/alembic/versions/0063_roms_metadata_player_count.py b/backend/alembic/versions/0063_roms_metadata_player_count.py index 7382851c6..b5329a02a 100644 --- a/backend/alembic/versions/0063_roms_metadata_player_count.py +++ b/backend/alembic/versions/0063_roms_metadata_player_count.py @@ -102,6 +102,7 @@ def upgrade(): NULLIF(r.manual_metadata ->> 'player_count', '1'), NULLIF(r.ss_metadata ->> 'player_count', '1'), NULLIF(r.igdb_metadata ->> 'player_count', '1'), + NULLIF(r.gamelist_metadata ->> 'player_count', '1'), '1' ) AS player_count, @@ -286,6 +287,7 @@ def upgrade(): NULLIF(JSON_UNQUOTE(JSON_EXTRACT(r.manual_metadata, '$.player_count')), '1'), NULLIF(JSON_UNQUOTE(JSON_EXTRACT(r.ss_metadata, '$.player_count')), '1'), NULLIF(JSON_UNQUOTE(JSON_EXTRACT(r.igdb_metadata, '$.player_count')), '1'), + NULLIF(JSON_UNQUOTE(JSON_EXTRACT(r.gamelist_metadata, '$.player_count')), '1'), '1' ) AS player_count, diff --git a/backend/handler/metadata/igdb_handler.py b/backend/handler/metadata/igdb_handler.py index 44c46c27e..ff5665ecc 100644 --- a/backend/handler/metadata/igdb_handler.py +++ b/backend/handler/metadata/igdb_handler.py @@ -177,15 +177,11 @@ def extract_metadata_from_igdb_rom( for mm in multiplayer_modes: platform_data = mm.get("platform") + igdb_id = -1 + name = "" if isinstance(platform_data, dict): - igdb_id = platform_data.get("id", 0) + igdb_id = platform_data.get("id", -1) name = platform_data.get("name", "") - elif isinstance(platform_data, int): - igdb_id = platform_data - name = "" - else: - igdb_id = 0 - name = "" multiplayer_modes_metadata.append( IGDBMetadataMultiplayerMode(