From 41cf73bbb709994ef978672fb4bf77c57411c985 Mon Sep 17 00:00:00 2001
From: Georges-Antoine Assi <contact@me.gantoine.com>
Date: Thu, 1 Jan 2026 11:32:14 -0500
Subject: [PATCH] changes from bot review

---
 .github/workflows/typecheck.yml |  2 +-
 frontend/package-lock.json      |  1 -
 frontend/src/views/Patcher.vue  | 28 +++++++++++++++-------------
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/typecheck.yml b/.github/workflows/typecheck.yml
index c75c12eda..b42b0bf20 100644
--- a/.github/workflows/typecheck.yml
+++ b/.github/workflows/typecheck.yml
@@ -37,5 +37,5 @@ jobs:
 
       - name: Lockfile lint
         run: |
-          [ -z "$(jq -r '.packages | to_entries[] | select((.key | contains("node_modules")) and (.value | has("resolved") and has("integrity") | not)) | .key' < package-lock.json)" ]
+          [ -z "$(jq -r '.packages | to_entries[] | select((.key | contains("node_modules")) and (.value.resolved | contains("git+ssh") | not) and (.value | has("resolved") and has("integrity") | not)) | .key' < package-lock.json)" ]
         working-directory: frontend
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
index 517c7a2a2..cdbc43bdc 100644
--- a/frontend/package-lock.json
+++ b/frontend/package-lock.json
@@ -7838,7 +7838,6 @@
     "node_modules/rom-patcher": {
       "version": "3.0.0",
       "resolved": "git+ssh://git@github.com/marcrobledo/RomPatcher.js.git#91e522e247f709e894761157ccba3189004d0859",
-      "integrity": "",
       "dependencies": {
         "chalk": "4.1.2",
         "commander": "^11.0.0"
diff --git a/frontend/src/views/Patcher.vue b/frontend/src/views/Patcher.vue
index 1ba845ff7..794665308 100644
--- a/frontend/src/views/Patcher.vue
+++ b/frontend/src/views/Patcher.vue
@@ -116,19 +116,21 @@ async function ensureCoreLoaded() {
       window.VCDIFF =
         null;
 
-    import("rom-patcher/rom-patcher-js/modules/BinFile.js");
-    import("rom-patcher/rom-patcher-js/modules/HashCalculator.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.aps_gba.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.aps_n64.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.bdf.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.bps.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ips.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.pmsr.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ppf.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.rup.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ups.js");
-    import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.vcdiff.js");
-    import("rom-patcher/rom-patcher-js/RomPatcher.js");
+    await Promise.all([
+      import("rom-patcher/rom-patcher-js/modules/BinFile.js"),
+      import("rom-patcher/rom-patcher-js/modules/HashCalculator.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.aps_gba.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.aps_n64.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.bdf.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.bps.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ips.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.pmsr.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ppf.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.rup.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.ups.js"),
+      import("rom-patcher/rom-patcher-js/modules/RomPatcher.format.vcdiff.js"),
+      import("rom-patcher/rom-patcher-js/RomPatcher.js"),
+    ]);
 
     coreLoaded.value = true;
   } catch (e: any) {