From 03c91affcdfd3725d7ac42d3112e6a70b8ea632e Mon Sep 17 00:00:00 2001
From: Georges-Antoine Assi <contact@me.gantoine.com>
Date: Fri, 21 Mar 2025 14:52:17 -0400
Subject: [PATCH] fix unclickable footer

---
 frontend/src/components/Settings/Footer.vue | 62 ++++++++++++---------
 frontend/src/locales/de_DE/settings.json    |  3 +-
 frontend/src/locales/en_GB/settings.json    |  3 +-
 frontend/src/locales/en_US/settings.json    |  3 +-
 frontend/src/locales/es_ES/settings.json    |  3 +-
 frontend/src/locales/fr_FR/settings.json    |  3 +-
 frontend/src/locales/ja_JP/settings.json    |  3 +-
 frontend/src/locales/ko_KR/settings.json    |  3 +-
 frontend/src/locales/pt_BR/settings.json    |  3 +-
 frontend/src/locales/ru_RU/settings.json    |  3 +-
 frontend/src/locales/zh_CN/settings.json    |  3 +-
 11 files changed, 47 insertions(+), 45 deletions(-)

diff --git a/frontend/src/components/Settings/Footer.vue b/frontend/src/components/Settings/Footer.vue
index 7486cee2e..130faab20 100644
--- a/frontend/src/components/Settings/Footer.vue
+++ b/frontend/src/components/Settings/Footer.vue
@@ -12,35 +12,48 @@ const heartbeatStore = storeHeartbeat();
   <div :class="{ desktop: !smAndDown }" class="sticky-bottom">
     <v-card class="bg-toplayer ma-2 pa-2">
       <v-row class="align-center justify-center" no-gutters>
-        <span class="ml-1">{{ heartbeatStore.value.SYSTEM.VERSION }}</span>
-        <v-icon>mdi-circle-small</v-icon><v-icon>mdi-github</v-icon>
         <v-hover v-slot="{ isHovering, props }">
-          <span class="ml-1"
-            ><a
-              :class="{
-                'text-primary': isHovering,
-              }"
-              v-bind="props"
-              style="text-decoration: none"
-              href="https://github.com/rommapp/romm"
-              target="_blank"
-              >Github</a
-            ></span
+          <a
+            :href="`https://github.com/rommapp/romm/releases/tag/${heartbeatStore.value.SYSTEM.VERSION}`"
+            target="_blank"
+            rel="noopener noreferrer"
+            class="text-decoration-none text-body-2"
+            v-bind="props"
+            :class="{
+              'text-secondary': isHovering,
+            }"
+          >
+            <code class="px-2 py-1 rounded-sm bg-surface text-primary">
+              {{ heartbeatStore.value.SYSTEM.VERSION }}
+            </code>
+          </a>
+        </v-hover>
+        <v-icon>mdi-circle-small</v-icon>
+        <v-hover v-slot="{ isHovering, props }">
+          <a
+            href="https://github.com/rommapp/romm"
+            target="_blank"
+            rel="noopener noreferrer"
+            class="text-decoration-none text-primary"
+            v-bind="props"
+            :class="{
+              'text-secondary': isHovering,
+            }"
+            >Github</a
           >
         </v-hover>
         <v-icon>mdi-circle-small</v-icon>
         <v-hover v-slot="{ isHovering, props }">
-          <span class="ml-1"
-            ><a
-              :class="{
-                'text-primary': isHovering,
-              }"
-              v-bind="props"
-              style="text-decoration: none"
-              href="https://discord.com/invite/P5HtHnhUDH"
-              target="_blank"
-              >{{ t("settings.join-discord") }}</a
-            ></span
+          <a
+            href="https://discord.com/invite/P5HtHnhUDH"
+            target="_blank"
+            rel="noopener noreferrer"
+            class="text-decoration-none text-primary"
+            v-bind="props"
+            :class="{
+              'text-secondary': isHovering,
+            }"
+            >Discord</a
           >
         </v-hover>
       </v-row>
@@ -54,7 +67,6 @@ const heartbeatStore = storeHeartbeat();
   left: 0;
   z-index: 1000;
   width: 100%;
-  pointer-events: none;
 }
 .desktop {
   margin-left: 60px !important;
diff --git a/frontend/src/locales/de_DE/settings.json b/frontend/src/locales/de_DE/settings.json
index d652d9f36..1df6abf50 100644
--- a/frontend/src/locales/de_DE/settings.json
+++ b/frontend/src/locales/de_DE/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Verzeichnisname",
   "romm-platform": "RomM Plattform",
   "platform-version": "Plattform-Version",
-  "main-platform": "Haupt-Plattform",
-  "join-discord": "Tritt unserem Discord bei"
+  "main-platform": "Haupt-Plattform"
 }
diff --git a/frontend/src/locales/en_GB/settings.json b/frontend/src/locales/en_GB/settings.json
index ef7eb40e2..4e1275d30 100644
--- a/frontend/src/locales/en_GB/settings.json
+++ b/frontend/src/locales/en_GB/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Folder name",
   "romm-platform": "RomM platform",
   "platform-version": "Platform version",
-  "main-platform": "Main platform",
-  "join-discord": "Join to our discord"
+  "main-platform": "Main platform"
 }
diff --git a/frontend/src/locales/en_US/settings.json b/frontend/src/locales/en_US/settings.json
index ef7eb40e2..4e1275d30 100644
--- a/frontend/src/locales/en_US/settings.json
+++ b/frontend/src/locales/en_US/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Folder name",
   "romm-platform": "RomM platform",
   "platform-version": "Platform version",
-  "main-platform": "Main platform",
-  "join-discord": "Join to our discord"
+  "main-platform": "Main platform"
 }
diff --git a/frontend/src/locales/es_ES/settings.json b/frontend/src/locales/es_ES/settings.json
index 28f24c6aa..b1327425f 100644
--- a/frontend/src/locales/es_ES/settings.json
+++ b/frontend/src/locales/es_ES/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Nombre de la carpeta",
   "romm-platform": "Plataforma en RomM",
   "platform-version": "Version de la plataforma",
-  "main-platform": "Plataforma principal",
-  "join-discord": "Únete a nuestro discord"
+  "main-platform": "Plataforma principal"
 }
diff --git a/frontend/src/locales/fr_FR/settings.json b/frontend/src/locales/fr_FR/settings.json
index dafc08515..d76f783f1 100644
--- a/frontend/src/locales/fr_FR/settings.json
+++ b/frontend/src/locales/fr_FR/settings.json
@@ -51,6 +51,5 @@
   "folder-name": "Nom du dossier",
   "romm-platform": "Plateforme RomM",
   "platform-version": "Version de la plateforme",
-  "main-platform": "Plateforme principale",
-  "join-discord": "Rejoignez notre Discord"
+  "main-platform": "Plateforme principale"
 }
diff --git a/frontend/src/locales/ja_JP/settings.json b/frontend/src/locales/ja_JP/settings.json
index 482b66fd9..529098cce 100644
--- a/frontend/src/locales/ja_JP/settings.json
+++ b/frontend/src/locales/ja_JP/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "フォルダ名",
   "romm-platform": "RomM プラットフォーム",
   "platform-version": "プラットフォームバージョン",
-  "main-platform": "メインプラットフォーム",
-  "join-discord": "Join to our discord"
+  "main-platform": "メインプラットフォーム"
 }
diff --git a/frontend/src/locales/ko_KR/settings.json b/frontend/src/locales/ko_KR/settings.json
index 89341fd8f..8d821b393 100644
--- a/frontend/src/locales/ko_KR/settings.json
+++ b/frontend/src/locales/ko_KR/settings.json
@@ -46,6 +46,5 @@
   "folder-name": "폴더 이름",
   "romm-platform": "RomM 플랫폼",
   "platform-version": "플랫폼 버전",
-  "main-platform": "메인 플랫폼",
-  "join-discord": "디스코드에 참여"
+  "main-platform": "메인 플랫폼"
 }
diff --git a/frontend/src/locales/pt_BR/settings.json b/frontend/src/locales/pt_BR/settings.json
index af4959333..f941f356b 100644
--- a/frontend/src/locales/pt_BR/settings.json
+++ b/frontend/src/locales/pt_BR/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Nome da pasta",
   "romm-platform": "Plataforma RomM",
   "platform-version": "Versão da plataforma",
-  "main-platform": "Plataforma principal",
-  "join-discord": "Junte-se ao nosso Discord"
+  "main-platform": "Plataforma principal"
 }
diff --git a/frontend/src/locales/ru_RU/settings.json b/frontend/src/locales/ru_RU/settings.json
index 030e6f9be..932a56400 100644
--- a/frontend/src/locales/ru_RU/settings.json
+++ b/frontend/src/locales/ru_RU/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "Имя папки",
   "romm-platform": "Платформа RomM",
   "platform-version": "Версия платформы",
-  "main-platform": "Основная платформа",
-  "join-discord": "Присоединяйтесь к нашему Discord"
+  "main-platform": "Основная платформа"
 }
diff --git a/frontend/src/locales/zh_CN/settings.json b/frontend/src/locales/zh_CN/settings.json
index e19970efc..bccc0b57e 100644
--- a/frontend/src/locales/zh_CN/settings.json
+++ b/frontend/src/locales/zh_CN/settings.json
@@ -50,6 +50,5 @@
   "folder-name": "文件夹名称",
   "romm-platform": "RomM 平台",
   "platform-version": "平台版本",
-  "main-platform": "主平台",
-  "join-discord": "加入我们的 Discord"
+  "main-platform": "主平台"
 }