From 1b081290d70244de6df55897063496bf3ac728ba Mon Sep 17 00:00:00 2001 From: Georges-Antoine Assi Date: Sun, 26 May 2024 22:29:55 -0400 Subject: [PATCH 1/9] fetch all roms on load lol --- frontend/src/services/api/rom.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/services/api/rom.ts b/frontend/src/services/api/rom.ts index 9a17e9873..1663a8b0d 100644 --- a/frontend/src/services/api/rom.ts +++ b/frontend/src/services/api/rom.ts @@ -32,7 +32,7 @@ async function uploadRoms({ async function getRoms({ platformId = null, - size = 60, + size = 5000, cursor = "", searchTerm = "", orderBy = "name", From 9fb3bb869e11f7864aae5bfe609e2a46a921360d Mon Sep 17 00:00:00 2001 From: Georges-Antoine Assi Date: Sun, 26 May 2024 22:41:29 -0400 Subject: [PATCH 2/9] use the lazy img component --- frontend/src/components/Game/Card/Cover.vue | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/frontend/src/components/Game/Card/Cover.vue b/frontend/src/components/Game/Card/Cover.vue index 09cbc0458..21dbee764 100644 --- a/frontend/src/components/Game/Card/Cover.vue +++ b/frontend/src/components/Game/Card/Cover.vue @@ -1,4 +1,5 @@ diff --git a/frontend/src/types/emitter.d.ts b/frontend/src/types/emitter.d.ts index d0b36199e..0c049aca2 100644 --- a/frontend/src/types/emitter.d.ts +++ b/frontend/src/types/emitter.d.ts @@ -68,6 +68,7 @@ export type Events = { filter: null; filterBarShow: null; filterBarReset: null; + updateDataTablePages: null; sortBarShow: null; romUpdated: DetailedRom; }; diff --git a/frontend/src/views/Gallery/Base.vue b/frontend/src/views/Gallery/Base.vue index 316bc4ac0..89fb700ac 100644 --- a/frontend/src/views/Gallery/Base.vue +++ b/frontend/src/views/Gallery/Base.vue @@ -113,6 +113,7 @@ async function onFilterChange() { return; } await fetchRoms(); + emitter?.emit("updateDataTablePages", null); } function selectRom({ event, index, selected }: RomSelectEvent) { @@ -309,6 +310,7 @@ onBeforeRouteUpdate(async (to, _) => { { Date: Tue, 28 May 2024 18:45:46 +0200 Subject: [PATCH 6/9] store romsPerPage in localStorage --- frontend/src/components/Game/DataTable/Base.vue | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frontend/src/components/Game/DataTable/Base.vue b/frontend/src/components/Game/DataTable/Base.vue index 8fe76ebaf..7ad10bc6c 100644 --- a/frontend/src/components/Game/DataTable/Base.vue +++ b/frontend/src/components/Game/DataTable/Base.vue @@ -78,7 +78,8 @@ const downloadStore = storeDownload(); const romsStore = storeRoms(); const auth = storeAuth(); const page = ref(1); -const romsPerPage = ref(10); +const storedRomsPerPage = parseInt(localStorage.getItem("romsPerPage") ?? ""); +const romsPerPage = ref(isNaN(storedRomsPerPage) ? 25 : storedRomsPerPage); const pageCount = ref(0); // Functions @@ -93,6 +94,7 @@ function updateDataTablePages() { } watch(romsPerPage, async () => { + localStorage.setItem("romsPerPage", romsPerPage.value.toString()); updateDataTablePages(); }); From dbe0769757d056b3bf189d6e3d6cbf624af912d5 Mon Sep 17 00:00:00 2001 From: zurdi Date: Tue, 28 May 2024 18:52:43 +0200 Subject: [PATCH 7/9] fixed per page options --- frontend/src/components/Game/DataTable/Base.vue | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/frontend/src/components/Game/DataTable/Base.vue b/frontend/src/components/Game/DataTable/Base.vue index 7ad10bc6c..2a7dade80 100644 --- a/frontend/src/components/Game/DataTable/Base.vue +++ b/frontend/src/components/Game/DataTable/Base.vue @@ -64,11 +64,7 @@ const HEADERS = [ { title: "", align: "end", key: "actions", sortable: false }, ] as const; -const PER_PAGE_OPTIONS = [ - { value: 25, title: "25" }, - { value: 50, title: "50" }, - { value: 100, title: "100" }, -] as const; +const PER_PAGE_OPTIONS = [10, 25, 50, 100]; const emitter = inject>("emitter"); emitter?.on("updateDataTablePages", updateDataTablePages); @@ -218,7 +214,7 @@ onMounted(() => { label="Roms per page" density="compact" variant="outlined" - :items="[10, 25, 50]" + :items="PER_PAGE_OPTIONS" v-model="romsPerPage" hide-details /> From 7b8e3ba9558e53a58687431eaea93b72d7d39ef5 Mon Sep 17 00:00:00 2001 From: zurdi Date: Tue, 28 May 2024 19:19:40 +0200 Subject: [PATCH 8/9] fixed what's new link --- frontend/src/components/Drawer/Footer.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/components/Drawer/Footer.vue b/frontend/src/components/Drawer/Footer.vue index ea869c672..0c0b4ad1e 100644 --- a/frontend/src/components/Drawer/Footer.vue +++ b/frontend/src/components/Drawer/Footer.vue @@ -29,10 +29,10 @@ onBeforeMount(async () => { "https://api.github.com/repos/rommapp/romm/releases/latest" ); const json = await response.json(); - GITHUB_VERSION.value = json.name; + GITHUB_VERSION.value = json.tag_name; latestVersionDismissed.value = VERSION === "development" || - json.name === localStorage.getItem("dismissedVersion"); + json.tag_name === localStorage.getItem("dismissedVersion"); }); async function logout() { @@ -108,7 +108,7 @@ async function logout() { New version available - {{ GITHUB_VERSION }}v{{ GITHUB_VERSION }} From 780dd371f7df6fbd15e42050cc731645bc73807a Mon Sep 17 00:00:00 2001 From: zurdi Date: Tue, 28 May 2024 19:27:06 +0200 Subject: [PATCH 9/9] reset itemsPerBatch on gallery change --- frontend/src/views/Gallery/Base.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend/src/views/Gallery/Base.vue b/frontend/src/views/Gallery/Base.vue index 89fb700ac..dc436b398 100644 --- a/frontend/src/views/Gallery/Base.vue +++ b/frontend/src/views/Gallery/Base.vue @@ -174,6 +174,7 @@ function resetGallery() { romsStore.reset(); scrolledToTop.value = true; galleryFilterStore.reset(); + itemsShown.value = itemsPerBatch.value; } function scrollToTop() {