From 5b7445f7589bf7e13f83b3bf002da4d2bcef5a7a Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Tue, 16 Dec 2025 00:02:34 +0000
Subject: [PATCH] fix(sensor-proxy): remove pct pull fallback that causes PVE
 task errors

The installer had a fallback that tried to copy the sensor-proxy binary from
inside the Pulse container using `pct pull`. However, the paths it tried
(/opt/pulse/bin/pulse-sensor-proxy-linux-amd64) don't exist in Pulse containers.

When pct pull fails, Proxmox logs a task error visible in the UI, even though
the error is harmless and expected. This caused recurring "TASK ERROR: failed
to open /opt/pulse/bin/pulse-sensor-proxy-linux-amd64: No such file or directory"
messages every time the selfheal timer ran and couldn't download from GitHub.

The pct pull approach was never going to succeed for LXC-installed Pulse instances
since the binary doesn't exist at those paths inside the container. Removing it
eliminates the spurious error messages.

Related to #817
---
 scripts/install-sensor-proxy.sh | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/scripts/install-sensor-proxy.sh b/scripts/install-sensor-proxy.sh
index 1bd81a8fa..d571ff3f7 100755
--- a/scripts/install-sensor-proxy.sh
+++ b/scripts/install-sensor-proxy.sh
@@ -1543,22 +1543,9 @@ sys.exit(0)
         fi
     fi
 
-    if [[ "$DOWNLOAD_SUCCESS" != true ]] && [[ -n "$CTID" ]] && command -v pct >/dev/null 2>&1; then
-        pull_targets=(
-            "/opt/pulse/bin/${BINARY_NAME}"
-            "/opt/pulse/bin/pulse-sensor-proxy"
-        )
-        for src in "${pull_targets[@]}"; do
-            tmp_pull=$(mktemp)
-            if pct pull "$CTID" "$src" "$tmp_pull" >/dev/null 2>&1; then
-                mv "$tmp_pull" "$BINARY_PATH.tmp"
-                print_info "Copied pulse-sensor-proxy binary from container $CTID ($src)"
-                DOWNLOAD_SUCCESS=true
-                break
-            fi
-            rm -f "$tmp_pull"
-        done
-    fi
+    # NOTE: Previous versions attempted pct pull from container paths like
+    # /opt/pulse/bin/pulse-sensor-proxy-linux-amd64, but these paths don't exist
+    # in Pulse containers. Removed to prevent spurious PVE task errors (#817).
 
     if [[ "$DOWNLOAD_SUCCESS" != true ]]; then
         print_error "Unable to download pulse-sensor-proxy binary."