diff --git a/internal/api/security_regression_test.go b/internal/api/security_regression_test.go index 7ebf8fdc0..6b4e38d05 100644 --- a/internal/api/security_regression_test.go +++ b/internal/api/security_regression_test.go @@ -1500,6 +1500,50 @@ func TestMetadataMutationEndpointsRequireMonitoringWriteScope(t *testing.T) { } } +func TestAISettingsReadRequiresSettingsReadScope(t *testing.T) { + rawToken := "ai-settings-read-token-123.12345678" + record := newTokenRecord(t, rawToken, []string{config.ScopeMonitoringRead}, nil) + cfg := newTestConfigWithTokens(t, record) + router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0") + + req := httptest.NewRequest(http.MethodGet, "/api/settings/ai", nil) + req.Header.Set("X-API-Token", rawToken) + rec := httptest.NewRecorder() + router.Handler().ServeHTTP(rec, req) + if rec.Code != http.StatusForbidden { + t.Fatalf("expected 403 for missing settings:read scope, got %d", rec.Code) + } + if !strings.Contains(rec.Body.String(), config.ScopeSettingsRead) { + t.Fatalf("expected missing scope response to mention %q, got %q", config.ScopeSettingsRead, rec.Body.String()) + } +} + +func TestAISettingsWriteRequiresSettingsWriteScope(t *testing.T) { + rawToken := "ai-settings-write-token-123.12345678" + record := newTokenRecord(t, rawToken, []string{config.ScopeSettingsRead}, nil) + cfg := newTestConfigWithTokens(t, record) + router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0") + + paths := []string{ + "/api/settings/ai/update", + "/api/ai/test", + "/api/ai/test/openai", + } + + for _, path := range paths { + req := httptest.NewRequest(http.MethodPost, path, strings.NewReader(`{}`)) + req.Header.Set("X-API-Token", rawToken) + rec := httptest.NewRecorder() + router.Handler().ServeHTTP(rec, req) + if rec.Code != http.StatusForbidden { + t.Fatalf("expected 403 for missing settings:write scope on %s, got %d", path, rec.Code) + } + if !strings.Contains(rec.Body.String(), config.ScopeSettingsWrite) { + t.Fatalf("expected missing scope response to mention %q, got %q", config.ScopeSettingsWrite, rec.Body.String()) + } + } +} + func TestSecurityOIDCRequiresSettingsWriteScope(t *testing.T) { rawToken := "security-oidc-token-123.12345678" record := newTokenRecord(t, rawToken, []string{config.ScopeSettingsRead}, nil)