gitea-mirror/Pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-02-18 00:17:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Require proxy admin for quick security setup

Browse Source
This commit is contained in:
rcourtman
2026-02-04 18:08:40 +00:00
parent b501820899
commit 4741307c4c
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
internal/api/security_regression_test.go
View File

@@ -2946,6 +2946,29 @@ func TestQuickSetupRequiresAuthWhenConfigured(t *testing.T) {
}
}
func TestQuickSetupRejectsProxyNonAdmin(t *testing.T) {
cfg := newTestConfigWithTokens(t)
cfg.AuthUser = "admin"
cfg.AuthPass = "hashed-password"
cfg.ProxyAuthSecret = "proxy-secret"
cfg.ProxyAuthUserHeader = "X-Remote-User"
cfg.ProxyAuthRoleHeader = "X-Remote-Roles"
cfg.ProxyAuthAdminRole = "admin"
router := NewRouter(cfg, nil, nil, nil, nil, "1.0.0")
ResetRateLimitForIP("203.0.113.27")
req := httptest.NewRequest(http.MethodPost, "/api/security/quick-setup", strings.NewReader(`{}`))
req.RemoteAddr = "203.0.113.27:1234"
req.Header.Set("X-Proxy-Secret", cfg.ProxyAuthSecret)
req.Header.Set("X-Remote-User", "viewer-user")
req.Header.Set("X-Remote-Roles", "viewer")
rec := httptest.NewRecorder()
router.Handler().ServeHTTP(rec, req)
if rec.Code != http.StatusForbidden {
t.Fatalf("expected 403 for non-admin proxy quick setup, got %d", rec.Code)
}
}
func TestRegenerateTokenRequiresAuthInAPIMode(t *testing.T) {
record := newTokenRecord(t, "regen-token-123.12345678", []string{config.ScopeSettingsWrite}, nil)
cfg := newTestConfigWithTokens(t, record)

11
internal/api/security_setup_fix.go
View File

@@ -154,6 +154,17 @@ func handleQuickSecuritySetupFixed(r *Router) http.HandlerFunc {
if !authorized && authConfigured {
wrapped := &responseCapture{ResponseWriter: w}
if CheckAuth(r.config, wrapped, req) {
// If proxy auth is configured, require admin role for changes.
if r.config.ProxyAuthSecret != "" {
if valid, username, isAdmin := CheckProxyAuth(r.config, req); valid && !isAdmin {
log.Warn().
Str("ip", clientIP).
Str("username", username).
Msg("Non-admin user attempted quick security setup")
http.Error(w, "Admin privileges required", http.StatusForbidden)
return
}
}
authorized = true
} else {
if !wrapped.wrote {